Skip to content

[Analytics Hub] Connect data and UI for Sessions analytics card #8409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 14, 2022
Merged

[Analytics Hub] Connect data and UI for Sessions analytics card #8409

merged 4 commits into from
Dec 14, 2022

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Dec 14, 2022

Closes: #8365

Description

This PR connects the data used for the sessions card (current period order stats and site summary stats) with the card UI.

For now, this will display placeholders and a sync error because we aren't fetching real data yet. The data will be fetched in another PR.

Changes

  • Adds a siteStats property to store the fetched SiteSummaryStats (currently always nil).
  • Adds a helper that returns a AnalyticsReportCardCurrentPeriodViewModel for the sessions card.
  • Localizes the card strings.

Testing

  1. Build and run the app.
  2. Tap "See more" to open the Analytics Hub.
  3. Confirm the Sessions card displays real data (placeholders and sync error for now).

Screenshots

Submitter Checklist

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added feature: stats Related to stats, including Top Performers. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels Dec 14, 2022
@rachelmcr rachelmcr added this to the 11.7 milestone Dec 14, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 14, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 14, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8409-03ebb79 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ealeksandrov ealeksandrov self-assigned this Dec 14, 2022
@rachelmcr
Copy link
Contributor Author

rachelmcr commented Dec 14, 2022

@ealeksandrov I see you're reviewing this, and just wanted to give you a heads up that I'd forgotten to bind the data to the card VM in bindViewModelsWithData(). I've just merged the latest from trunk and added that binding, which should make these changes complete.

ealeksandrov
ealeksandrov approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@ealeksandrov ealeksandrov removed their assignment Dec 14, 2022
@rachelmcr rachelmcr merged commit dd6a894 into trunk Dec 14, 2022
@rachelmcr rachelmcr deleted the issue/8365-sessions-data-ui branch December 14, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ecarrion Ecarrion Awaiting requested review from Ecarrion

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@ealeksandrov ealeksandrov ealeksandrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: stats Related to stats, including Top Performers. status: feature-flagged Behind a feature flag. Milestone is not strongly held.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Integrate data and UI for Sessions analytics card

4 participants

@rachelmcr @wpmobilebot @ealeksandrov